Flashlight/lighting bug is still around (Sorry, Abby)

Locked
User avatar
Juninho77
Registered user
Posts: 276
Joined: 06 May 2015, 10:22

Flashlight/lighting bug is still around (Sorry, Abby)

Post by Juninho77 » 27 May 2015, 21:11

Bug Description:
The light bug is still plaguing us.

Steps to reproduce:
http://youtu.be/0xKs0ipcIFc

Dafuq's going on:
I've taken some glances at the code. I think I know just what's happening.

There is a ceiling for luminosity. I could not quite find the piece of code that defines it, but flashlights become ineffective at some point. Let's say, for the sake of the argument, that that ceiling is 8. A flare gives 7, a flashlight gives 4. You add them up, you'd get an 11, but our ceiling is 8, so your luminosity is 8. And then you turn off your flashlight. What happens? Your luminosity drops by 4 points, down to 4, even though you're holding a flare, which gives 7 luminosity.

My fix for this would be creating a second variable - say "actual luminosity" - to keep track of the... Actual luminosity your character is carrying. When removing luminosity, you'd remove luminosity from this "actual luminosity" variable and then apply it to the player - after adjusting, if necessary, for the ceiling. But I can't code in BYOND, so that's up to you.
Image
"Do not go gentle into that good night; rage, rage against the dying of the light."
If you would permaban a player, you owe it to him to look into his logs and hear his side of the story. And if you cannot bear to do that, then perhaps the player does not deserve to be banned.
Image

User avatar
valzargaming
Registered user
Posts: 89
Joined: 10 May 2015, 21:09

Re: Flashlight/lighting bug is still around (Sorry, Abby)

Post by valzargaming » 28 May 2015, 19:42

I believe I reported this issue earlier using the same information you posted here.
Come on apo, get on it.

User avatar
apophis775
Host
Host
Posts: 6985
Joined: 22 Aug 2014, 18:05
Location: Ice Colony
Byond: Apophis775
Contact:

Re: Flashlight/lighting bug is still around (Sorry, Abby)

Post by apophis775 » 04 Jun 2015, 12:17

We are focusing on the alpha, while we are doing some bugfixes, the majority of our work, is going into the alpha.

I'll look into this, but keep in mind, that I work 2 jobs and have limited time to code.

User avatar
Juninho77
Registered user
Posts: 276
Joined: 06 May 2015, 10:22

Re: Flashlight/lighting bug is still around (Sorry, Abby)

Post by Juninho77 » 23 Jun 2015, 05:48

Fixed.

Fun thing, this one was caused not by one, but two different bugs in two different files (1, 2).
Image
"Do not go gentle into that good night; rage, rage against the dying of the light."
If you would permaban a player, you owe it to him to look into his logs and hear his side of the story. And if you cannot bear to do that, then perhaps the player does not deserve to be banned.
Image

Locked