R&D database exploit

fix pls
Locked
User avatar
mullvad
Registered user
Posts: 63
Joined: 12 Dec 2016, 06:40
Byond: mullvad

R&D database exploit

Post by mullvad » 12 Dec 2016, 09:25

Bug Description:

/obj/machinery/computer/WYresearch/Topic spawns an alert() but it does not verify if the usr is still allowed to process this alert.

Steps to reproduce:
1. Run up to the R&D console
2. Reset the database but keep the popup open.
3. Run away or die.
4. Hit the button.
5. BWOINK!

User avatar
Snypehunter007
Registered user
Posts: 2750
Joined: 02 Dec 2015, 17:14
Location: Georgia
Byond: Snypehunter007
Contact:

Re: R&D database exploit

Post by Snypehunter007 » 20 Dec 2016, 00:37

Had this tested. Unable to recreate.

Unless this happens again, asking this to be locked.
Reached "Leet" post status on 3/14/17.
Death of the Suggestion Killer - 11/30/2017

Staff History:
► Show Spoiler
Image

User avatar
mullvad
Registered user
Posts: 63
Joined: 12 Dec 2016, 06:40
Byond: mullvad

Re: R&D database exploit

Post by mullvad » 20 Dec 2016, 13:04

This still works.

Code: Select all

	else if(href_list["reset"]) // <-- This is called when you hit the reset button.
		var/choice = alert("R&D Console Database Reset", "Are you sure you want to reset the R&D console's database? Data lost cannot be recovered.", "Continue", "Cancel") // <-- This is the alert that pops up
		if(choice == "Continue") // <-- This is missing proper checks to ensure the player is still there.
			screen = 0.0
			del(files)
			files = new /datum/research(src)
			spawn(20)
				screen = 1.6
				updateUsrDialog()

User avatar
Surrealistik
Registered user
Posts: 1870
Joined: 04 Jul 2015, 17:57

Re: R&D database exploit

Post by Surrealistik » 20 Dec 2016, 14:22

I attempted to reset the console and didn't receive the confirmation prompt.
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Field Engineer Guide
Medbay Guide
Utility PFC Guide

Locked