Fix Iron Bears surnames

Locked
User avatar
Neray
Registered user
Posts: 326
Joined: 23 Dec 2014, 22:36

Fix Iron Bears surnames

Post by Neray » 10 Aug 2016, 18:05

Summary (a quick, 2-3 sentence summary):
Topic. That was bothering me for a long time.

Benefits (How this will benefit the server and game as a whole):
It's just a small grammar fix.

Implementation (Optional, if you have an idea how to implement it):
All women surnames ending with consonant should end with -a.

For example: Ivan Ivanov, but, Elena Ivanova. There're some exceptions but since there're no rare surnames in Bears list (Lurie, as example), no point bothering with em.

Here's a full list of fixed surnames, you just need to add it as second list to ERT name generation.

User avatar
NoahKirchner
Registered user
Posts: 1738
Joined: 02 Aug 2016, 15:58
Location: Sea of Tranquility, Luna
Byond: NoahKirchner
Contact:

Re: Fix Iron Bears surnames

Post by NoahKirchner » 10 Aug 2016, 18:09

+1 Because why not
► Show Spoiler

Egorkor
Registered user
Posts: 570
Joined: 10 Aug 2015, 08:23

Re: Fix Iron Bears surnames

Post by Egorkor » 10 Aug 2016, 18:22

by extension fix all the people that play a wannabe russian female with a male surname and a horrible accent :^)

User avatar
SecretStamos (Joshuu)
Registered user
Posts: 1291
Joined: 15 Oct 2014, 12:32
Location: Stars & Stripes

Re: Fix Iron Bears surnames

Post by SecretStamos (Joshuu) » 10 Aug 2016, 22:05

We pull our surnames from a large collected list. It would require a quite a bit of additional code to check if the first name is a woman's name, and if it ends with an "a".

Doable, but a lot more effort than I feel it's worth. We have a lot more pressing issues to attend to, and a limited number of people to do it.

User avatar
Neray
Registered user
Posts: 326
Joined: 23 Dec 2014, 22:36

Re: Fix Iron Bears surnames

Post by Neray » 10 Aug 2016, 22:13

SecretStamos (Joshuu) wrote:We pull our surnames from a large collected list. It would require a quite a bit of additional code to check if the first name is a woman's name, and if it ends with an "a".

Doable, but a lot more effort than I feel it's worth. We have a lot more pressing issues to attend to, and a limited number of people to do it.
No point fixing all random names (even though I was unable to find those russian surnames anywhere except for ERT). Just fix this ERT list. Make a copy replacing surnames as I listed, give it another, I don't know, -rw ending and change part with women name generation from r list to rw list. 1 minute, plus 10 seconds to find this part of code.

I can make another suggestion later on after you'll finish working with more important stuff listing fixed surnames for general name generation. Thanks to that leaked version I've got something to work with.

UPD: Look, I've even done that for you.

UPD2: I was talking about last names and those are being taken from a very short list stated right in Iron Bears ERT spawning. As well as names, though.

UPD3: Did you seriously think about making a part of code that will check gender? ._.

User avatar
forwardslashN
Community Contributor
Community Contributor
Posts: 2495
Joined: 14 Dec 2015, 23:12
Byond: forwardslashN

Re: Fix Iron Bears surnames

Post by forwardslashN » 10 Aug 2016, 22:56

Resolved.
Image
The ambivalent giant white baldie in a jungle near you.

Locked